- 
                Notifications
    
You must be signed in to change notification settings  - Fork 115
 
[DOCS] Edit ingest ip_location summaries #3390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
           Following you can find the validation results for the APIs you have changed. 
 You can validate these APIs yourself by using the   | 
    
        
          
                specification/ingest/delete_ip_location_database/DeleteIpLocationDatabaseRequest.ts
              
                Outdated
          
            Show resolved
            Hide resolved
        
      
              
                    shainaraskas
  
              
              approved these changes
              
                  
                    Dec 31, 2024 
                  
              
              
            
            
…ionDatabaseRequest.ts Co-authored-by: shainaraskas <[email protected]>
| 
           Following you can find the validation results for the APIs you have changed. 
 You can validate these APIs yourself by using the   | 
    
    
  github-actions bot
      pushed a commit
      that referenced
      this pull request
    
      Dec 31, 2024 
    
    
      
  
    
      
    
  
Co-authored-by: shainaraskas <[email protected]> (cherry picked from commit 60ad301)
    
  github-actions bot
      pushed a commit
      that referenced
      this pull request
    
      Dec 31, 2024 
    
    
      
  
    
      
    
  
Co-authored-by: shainaraskas <[email protected]> (cherry picked from commit 60ad301)
    
  lcawl 
      added a commit
      that referenced
      this pull request
    
      Jan 7, 2025 
    
    
      
  
    
      
    
  
* [DOCS] Edit ingest ip_location summaries (#3390) Co-authored-by: shainaraskas <[email protected]> (cherry picked from commit 60ad301) * Regenerate output --------- Co-authored-by: Lisa Cawley <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This PR edits some summaries and descriptions in the ingest APIs based on information derived from https://www.elastic.co/guide/en/elasticsearch/reference/master/delete-ip-location-database-api.html, https://www.elastic.co/guide/en/elasticsearch/reference/master/get-ip-location-database-api.html, and https://www.elastic.co/guide/en/elasticsearch/reference/master/put-ip-location-database-api.html.
NOTE: https://www.elastic.co/guide/en/elasticsearch/reference/master/put-geoip-database-api.html exists only in the "deleted pages" section of the Elasticsearch Guide, so I'm assuming it will eventually be deprecated and removed from the specifications but that doesn't seem to have happened yet.